Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set max version for pyocient #24556

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

jwilliams-ocient
Copy link
Contributor

@jwilliams-ocient jwilliams-ocient commented Jun 29, 2023

SUMMARY

pyocient 2.x ad 3.x introduce a number of API changes that break Deck.gl chart integrations for point, linestring, and polygon data types. By setting a max range, we ensure Superset users do not pull in these breaking changes.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

There's no point in supporting 2.x.x here
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #24556 (1d98bce) into master (19deb91) will increase coverage by 0.01%.
The diff coverage is 60.36%.

❗ Current head 1d98bce differs from pull request most recent head 58fe29d. Consider uploading reports for the commit 58fe29d to get more accurate results

@@            Coverage Diff             @@
##           master   #24556      +/-   ##
==========================================
+ Coverage   69.08%   69.10%   +0.01%     
==========================================
  Files        1906     1906              
  Lines       74120    74175      +55     
  Branches     8154     8163       +9     
==========================================
+ Hits        51207    51259      +52     
+ Misses      20794    20788       -6     
- Partials     2119     2128       +9     
Flag Coverage Δ
hive 53.93% <47.05%> (-0.01%) ⬇️
mysql 79.39% <74.50%> (-0.01%) ⬇️
postgres 79.48% <74.50%> (-0.01%) ⬇️
presto 53.83% <47.05%> (-0.01%) ⬇️
python 83.48% <80.39%> (-0.01%) ⬇️
sqlite 78.04% <74.50%> (-0.01%) ⬇️
unit 54.69% <64.70%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-ui-chart-controls/src/components/labelUtils.tsx 100.00% <ø> (ø)
...erset-frontend/src/SqlLab/components/App/index.jsx 82.60% <ø> (-0.73%) ⬇️
superset-frontend/src/SqlLab/reducers/sqlLab.js 48.25% <ø> (ø)
superset-frontend/src/components/Tooltip/index.tsx 100.00% <ø> (ø)
...ses/DatabaseModal/DatabaseConnectionForm/index.tsx 81.81% <ø> (ø)
superset-frontend/src/logger/LogUtils.ts 97.22% <ø> (ø)
superset/reports/api.py 90.29% <ø> (ø)
superset-frontend/src/views/CRUD/hooks.ts 52.38% <11.11%> (-0.76%) ⬇️
...end/src/features/databases/DatabaseModal/index.tsx 43.55% <42.85%> (-0.09%) ⬇️
superset/charts/api.py 87.78% <50.00%> (ø)
... and 15 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina
Copy link
Member

Hi @jwilliams-ocient. Thanks for the PR. Could you add a description to your PR?

@jwilliams-ocient
Copy link
Contributor Author

Thanks for taking a look @michael-s-molina ! My apologies for not providing a description 🤦🏾 . Lmk if you have any more questions.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix @jwilliams-ocient!

@michael-s-molina michael-s-molina changed the title chore: set max version for pyocient. Version 3.0 renames a data type … fix: set max version for pyocient. Version 3.0 renames a data type … Jul 6, 2023
@michael-s-molina michael-s-molina changed the title fix: set max version for pyocient. Version 3.0 renames a data type … fix: set max version for pyocient Jul 6, 2023
@michael-s-molina michael-s-molina merged commit 64d728f into apache:master Jul 6, 2023
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jul 7, 2023
michael-s-molina pushed a commit that referenced this pull request Jul 26, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants