-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set max version for pyocient #24556
Conversation
There's no point in supporting 2.x.x here
Codecov Report
@@ Coverage Diff @@
## master #24556 +/- ##
==========================================
+ Coverage 69.08% 69.10% +0.01%
==========================================
Files 1906 1906
Lines 74120 74175 +55
Branches 8154 8163 +9
==========================================
+ Hits 51207 51259 +52
+ Misses 20794 20788 -6
- Partials 2119 2128 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hi @jwilliams-ocient. Thanks for the PR. Could you add a description to your PR? |
Thanks for taking a look @michael-s-molina ! My apologies for not providing a description 🤦🏾 . Lmk if you have any more questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the fix @jwilliams-ocient!
(cherry picked from commit 64d728f)
SUMMARY
pyocient
2.x ad 3.x introduce a number of API changes that break Deck.gl chart integrations for point, linestring, and polygon data types. By setting a max range, we ensure Superset users do not pull in these breaking changes.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION