Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clicking on a tag in the dashboard and charts lists does not work #24593

Merged

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Jul 5, 2023

SUMMARY

Fixes a bug when clicking on a tag in the dashboard and charts that lead to 404 error. The reason was that the all entities route was not registered on the server side leading to the error.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: Clicking on a tag pill led to a 404

Screenshot 2023-07-05 at 10 33 08

After: Clicking on a tag correctly shows the page

Screenshot 2023-07-05 at 11 20 31

TESTING INSTRUCTIONS

1 - Enable TAGGING_SYSTEM feature flag.
2 - Edit a chart and tag it
3 - From the chart list, click on the tag pill
4 - It should show the tag page

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #24593 (42e0ddd) into master (a4880ca) will increase coverage by 10.82%.
The diff coverage is 100.00%.

❗ Current head 42e0ddd differs from pull request most recent head e14b2b8. Consider uploading reports for the commit e14b2b8 to get more accurate results

@@             Coverage Diff             @@
##           master   #24593       +/-   ##
===========================================
+ Coverage   58.28%   69.10%   +10.82%     
===========================================
  Files        1906     1906               
  Lines       74175    74176        +1     
  Branches     8164     8164               
===========================================
+ Hits        43233    51260     +8027     
+ Misses      28814    20788     -8026     
  Partials     2128     2128               
Flag Coverage Δ
hive 53.93% <100.00%> (+<0.01%) ⬆️
mysql 79.39% <100.00%> (?)
postgres 79.48% <100.00%> (?)
presto 53.83% <100.00%> (+<0.01%) ⬆️
python 83.48% <100.00%> (+22.53%) ⬆️
sqlite 78.04% <100.00%> (?)
unit 54.69% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/initialization/__init__.py 91.07% <100.00%> (+0.02%) ⬆️

... and 301 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jul 5, 2023
@michael-s-molina michael-s-molina merged commit 04ae259 into apache:master Jul 5, 2023
36 checks passed
michael-s-molina added a commit that referenced this pull request Jul 26, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants