-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(view_api): return application/json as content-type for api/v1/form_data endpoint #24758
chore(view_api): return application/json as content-type for api/v1/form_data endpoint #24758
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24758 +/- ##
=======================================
Coverage 68.94% 68.95%
=======================================
Files 1901 1902 +1
Lines 73898 73939 +41
Branches 8175 8176 +1
=======================================
+ Hits 50951 50981 +30
- Misses 20834 20845 +11
Partials 2113 2113
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -86,7 +86,7 @@ def query_form_data(self) -> FlaskResponse: # pylint: disable=no-self-use | |||
|
|||
update_time_range(form_data) | |||
|
|||
return json.dumps(form_data) | |||
return self.json_response(form_data) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
…views/api
SUMMARY
application/json
forapi/v1/form_data
endpoint.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION