fix: Removes unnecessary query on filters

[michael-s-molina]

SUMMARY

This PR removes an unnecessary query that was being fired by filters with "Dynamically search all filter values" enabled.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-07-26.at.09.15.14.mov

Screen.Recording.2023-07-26.at.09.17.16.mov

TESTING INSTRUCTIONS

• Create a filter with "Dynamically search all filter values" enabled
• Check that the unnecessary query was removed

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #24814 (9de0418) into master (a9c4472) will decrease coverage by 0.12%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 9de0418 differs from pull request most recent head 8ab50ab. Consider uploading reports for the commit 8ab50ab to get more accurate results

@@            Coverage Diff             @@
##           master   #24814      +/-   ##
==========================================
- Coverage   68.95%   68.84%   -0.12%     
==========================================
  Files        1902     1902              
  Lines       73997    73992       -5     
  Branches     8195     8194       -1     
==========================================
- Hits        51028    50939      -89     
- Misses      20850    20934      +84     
  Partials     2119     2119              

Flag	Coverage Δ
hive	?
javascript	55.78% <ø> (-0.01%)	⬇️
sqlite	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...c/filters/components/Select/SelectFilterPlugin.tsx	59.21% <ø> (-2.52%)	⬇️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[kgabryje]

Looks good, but are we sure that there isn't any edge case that clearSuggestionSearch was handling? CC @villebro since he added that function back in 2021

[michael-s-molina]

Looks good, but are we sure that there isn't any edge case that clearSuggestionSearch was handling? CC @villebro since he added that function back in 2021

Referencing #23869 for more context.

[kgabryje]

LGTM