fix(explore): invalid "No Filter" applied #24876
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When a legacy chart converted to the echart, there's a chance that non time range filter has been added in the adhoc_filters. This
No Filter
value has been introduced from https://github.com/apache/superset/pull/24405/files which always addsNo Filter
any given filter types. This commit adds the condition thatNo Filter
added only forTEMPORAL_RANGE
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
No filter
ignoredBefore:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION