Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashboard import/export): include additional fields to export/import commands #24941

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

Vitor-Avila
Copy link
Contributor

@Vitor-Avila Vitor-Avila commented Aug 10, 2023

SUMMARY

Similar to #22471, this PR adds the fields below to the dashboard export/import flow:

  • published
  • certified_by
  • certification_details

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. Create a dashboard.
  2. Publish it and add certification information.
  3. Export the dashboard.
  4. Validate that published is set to true in the YAML, and also that certification info was exported.
  5. Convert the dashboard to draft and remove certification info.
  6. Import it. Validate that certification info and status were updated.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@Vitor-Avila Vitor-Avila marked this pull request as draft August 10, 2023 00:59
@Vitor-Avila Vitor-Avila marked this pull request as ready for review August 10, 2023 01:03
@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #24941 (1565763) into master (ec9e9a4) will decrease coverage by 0.04%.
Report is 5 commits behind head on master.
The diff coverage is 74.62%.

❗ Current head 1565763 differs from pull request most recent head 3c61ea8. Consider uploading reports for the commit 3c61ea8 to get more accurate results

@@            Coverage Diff             @@
##           master   #24941      +/-   ##
==========================================
- Coverage   69.00%   68.96%   -0.04%     
==========================================
  Files        1906     1906              
  Lines       74133    74152      +19     
  Branches     8208     8211       +3     
==========================================
- Hits        51153    51138      -15     
- Misses      20857    20890      +33     
- Partials     2123     2124       +1     
Flag Coverage Δ
hive 54.18% <27.86%> (+<0.01%) ⬆️
mysql ?
postgres 79.32% <72.13%> (+<0.01%) ⬆️
presto 54.08% <27.86%> (+<0.01%) ⬆️
python 83.28% <72.13%> (-0.09%) ⬇️
sqlite ?
unit 55.05% <27.86%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rset-frontend/src/components/ErrorMessage/types.ts 100.00% <ø> (ø)
superset-frontend/src/dashboard/actions/hydrate.js 2.04% <ø> (ø)
...et-frontend/src/dashboard/components/SaveModal.tsx 39.28% <ø> (ø)
superset/cli/native_filters.py 0.00% <0.00%> (ø)
superset/databases/api.py 89.95% <ø> (ø)
...uperset/utils/dashboard_filter_scopes_converter.py 15.38% <0.00%> (-0.41%) ⬇️
superset/security/manager.py 94.43% <94.44%> (ø)
...set-frontend/src/dashboard/util/permissionUtils.ts 88.23% <100.00%> (+1.56%) ⬆️
...eatures/databases/DatabaseModal/SqlAlchemyForm.tsx 63.63% <100.00%> (+2.09%) ⬆️
...end/src/features/databases/DatabaseModal/index.tsx 43.66% <100.00%> (ø)
... and 8 more

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@john-bodley
Copy link
Member

Thanks @Vitor-Avila for the change. Once you fix the CI issues we can merge this.

@Vitor-Avila
Copy link
Contributor Author

thanks @john-bodley! I'm not sure why that test is failing only for two DB Engines. I'm spinning up a local MySQL to further debug this.

@betodealmeida betodealmeida merged commit cacad56 into apache:master Aug 14, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants