fix: Don't let users see dashboards only because it's favorited

[jfrag1]

SUMMARY

I initially was looking into this due to this issue: #19849, however I found the issue was mostly fixed on master. Access to charts and datasets of the dashboard is revoked when the role is revoked. However, favorited dashboards that the user shouldn't have access to otherwise still show up on the dashboard listview, which I think is undesired since trying to click on that dashboard then results in an error.

This PR makes it so that favorite status is not taken into consideration by the list dashboards endpoint.

Fixes #19849

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue: Fixes Dashboard RBAC Favourite issue #19849
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[michael-s-molina]

@jfrag1 Is this the last piece to fix #19849? If so, could you add "Fixes #19849" to your PR description so that when this PR is merged the issue is also closed?

[jfrag1]

@jfrag1 Is this the last piece to fix #19849? If so, could you add "Fixes #19849" to your PR description so that when this PR is merged the issue is also closed?

Yes it should be. I didn't know about that integration, added

[michael-s-molina]

I don't know why it does not work in the Has associated issue section but I added to the default description and I can confirm the issue will be closed once this PR is merged.

[michael-s-molina]

LGTM. Thanks for the fix @jfrag1!