-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-chart-echarts): support numerical x-axis #26087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #26087 +/- ##
=======================================
Coverage 69.07% 69.07%
=======================================
Files 1941 1941
Lines 75882 75885 +3
Branches 8443 8445 +2
=======================================
+ Hits 52412 52416 +4
+ Misses 21295 21294 -1
Partials 2175 2175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
(cherry picked from commit aad67e4)
SUMMARY
Currently using a numeric x-axis produces a chart with a categorical x-axis. This sets the x-axis to
AFTER
Now the x-axis is numerical:
BEFORE
Previously the x-axis was set as categorical:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION