fix: flaky test_explore_json_async test v2 #26106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26106 +/- ##
===========================================
- Coverage 69.10% 58.93% -10.18%
===========================================
Files 1940 1940
Lines 75869 75869
Branches 8445 8445
===========================================
- Hits 52427 44710 -7717
- Misses 21267 28984 +7717
Partials 2175 2175
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
michael-s-molina
approved these changes
Nov 28, 2023
michael-s-molina
added
the
v3.0
john-bodley
reviewed
Nov 29, 2023
| self.assertCountEqual( | ||
| keys, ["channel_id", "job_id", "user_id", "status", "errors", "result_url"] | ||
| ) | ||
| assert rv.status_code in {200, 202} |
There was a problem hiding this comment.
@villebro I was wondering whether it would be easier/simpler to disable the caching for this test so the response status code is always 200. The only caveat is whether we should be testing both scenarios.
There was a problem hiding this comment.
@john-bodley yeah, totally. I tried to do that a long time ago, but things got really weird. I figured I'll rewrite this test when we start preparing for GAQ for real.
michael-s-molina
pushed a commit
that referenced
this pull request
Dec 4, 2023
(cherry picked from commit 91a8b69)
josedev-union
pushed a commit
to Ortege-xyz/studio
that referenced
this pull request
Jan 22, 2024
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🍒 3.0.3
🍒 3.0.4
🏷️ bot
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
#26059 relaxed the assertion in
test_explore_json_asyncto not fail if the result was already cached. However, since the response payload is different for the 202 response, the test still fails if a 200 is received. This PR changes the assertion from the legacyself.assertnotation to the preferredassertone, and makes thekeysassertion both conditional on a 202 response, and explicitly asserts the returned keys, instead of the key count.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION