Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(adt): add 403 to api response status codes #27162

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

anirudh-hegde
Copy link
Contributor

I added a status code 403 as it will be helpful for methods like GET, PUT, POST etc… and for troubleshooting errors for the development team.

@github-actions github-actions bot added the api Related to the REST API label Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8dc6cbe) 69.52% compared to head (c463e48) 69.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #27162   +/-   ##
=======================================
  Coverage   69.52%   69.52%           
=======================================
  Files        1905     1905           
  Lines       74498    74498           
  Branches     8323     8323           
=======================================
  Hits        51794    51794           
  Misses      20649    20649           
  Partials     2055     2055           
Flag Coverage Δ
hive 53.79% <ø> (ø)
mysql 78.00% <ø> (ø)
postgres 78.10% <ø> (ø)
presto 53.74% <ø> (ø)
python 83.07% <ø> (ø)
sqlite 77.62% <ø> (ø)
unit 56.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anirudh-hegde
Copy link
Contributor Author

I cloned my superset repo with branch hammer
I executed pylint api.py.

image

@villebro villebro changed the title Added(status code) : to api.py feat(api): add 403 to response types Feb 20, 2024
@villebro villebro changed the title feat(api): add 403 to response types feat(adt): add 403 to api response status codes Feb 20, 2024
@villebro
Copy link
Member

@anirudh-hegde the lint error was wrt the PR title

@dpgaspar dpgaspar merged commit b8fc2e5 into apache:master Feb 20, 2024
42 of 44 checks passed
@anirudh-hegde anirudh-hegde deleted the hammer branch February 20, 2024 15:13
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to the REST API size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants