Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade setuptools/pip in Dockerfile #27405

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Mar 6, 2024

Making sure that pip and setuptools are the latest in our Dockerfile

closes #27405

Removing setuptools from requirements/development.in as it's bad
practice to touch the setuptools while setting up tools, and moving
that to the Dockerfile, insuring latest pip and setuptools there
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (69d870c) to head (489ff0c).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27405      +/-   ##
==========================================
- Coverage   69.71%   69.60%   -0.11%     
==========================================
  Files        1909     1909              
  Lines       74604    74619      +15     
  Branches     8323     8323              
==========================================
- Hits        52008    51937      -71     
- Misses      20544    20630      +86     
  Partials     2052     2052              
Flag Coverage Δ
hive ?
mysql 77.97% <ø> (+0.01%) ⬆️
postgres 78.10% <ø> (+0.01%) ⬆️
presto ?
python 82.90% <ø> (-0.24%) ⬇️
sqlite 77.61% <ø> (+0.01%) ⬆️
unit 56.54% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pull-request-size pull-request-size bot added size/XS and removed size/S labels Mar 6, 2024
@john-bodley
Copy link
Member

john-bodley commented Mar 6, 2024

@mistercrunch I don't see the requirements/development.in file in your PR? Note I agree with your thought process about not having setuptools as an explicit dependency.

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Mar 6, 2024
@mistercrunch
Copy link
Member Author

I thought I was stuck and couldn't run pip-compile-multi since it's busted, but I just found its --no-upgrade flag which did work just now.

BTW keep running in some issue where pip-compile-multi replaces the . in -e file:. to the full local path in my local computer randomly and I have to replace back to a . manually. Luckily it doesn't mess up the hash that pip-compile-multi manages.

@mistercrunch
Copy link
Member Author

Oh btw, note that even after removing setuptools from requirements/development.in, all of our requirements/*.txt files still have that message:

# The following packages are considered to be unsafe in a requirements file:
# setuptools

@mistercrunch
Copy link
Member Author

@john-bodley I think I addressed your point, let me know if there's anything else

@mistercrunch mistercrunch merged commit 372cac9 into master Mar 11, 2024
27 of 28 checks passed
@mistercrunch mistercrunch deleted the upgrade_setuptools branch March 11, 2024 16:42
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants