-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade setuptools/pip in Dockerfile #27405
Conversation
Removing setuptools from requirements/development.in as it's bad practice to touch the setuptools while setting up tools, and moving that to the Dockerfile, insuring latest pip and setuptools there
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27405 +/- ##
==========================================
- Coverage 69.71% 69.60% -0.11%
==========================================
Files 1909 1909
Lines 74604 74619 +15
Branches 8323 8323
==========================================
- Hits 52008 51937 -71
- Misses 20544 20630 +86
Partials 2052 2052
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@mistercrunch I don't see the |
I thought I was stuck and couldn't run pip-compile-multi since it's busted, but I just found its BTW keep running in some issue where pip-compile-multi replaces the |
Oh btw, note that even after removing setuptools from
|
@john-bodley I think I addressed your point, let me know if there's anything else |
Making sure that pip and setuptools are the latest in our Dockerfile
closes #27405