test(Migration to RTL): Refactor ActivityTable.test.tsx from Enzyme to RTL #27422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27422 +/- ##
==========================================
+ Coverage 67.46% 67.49% +0.02%
==========================================
Files 1910 1910
Lines 74812 74820 +8
Branches 8346 8353 +7
==========================================
+ Hits 50474 50497 +23
+ Misses 22286 22273 -13
+ Partials 2052 2050 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
justinpark
reviewed
Mar 7, 2024
justinpark
reviewed
Mar 7, 2024
rtexelm
force-pushed
the
chore/to-rtl-src-features-home-activitytable-test/sc-79134
branch
from
e4c6a75
to
e19f014
Compare
9 tasks
rtexelm
force-pushed
the
chore/to-rtl-src-features-home-activitytable-test/sc-79134
branch
from
e19f014
to
f7423a3
Compare
|
Added a small change in |
|
@justinpark is this looking better? |
|
looks like you'll have to rebase, we address the issue with the missing required checks. |
rtexelm
force-pushed
the
chore/to-rtl-src-features-home-activitytable-test/sc-79134
branch
from
f7423a3
to
1ce11f7
Compare
EandrewJones
pushed a commit
to UMD-ARLIS/superset
that referenced
this pull request
Apr 5, 2024
EnxDev
pushed a commit
to EnxDev/superset
that referenced
this pull request
Apr 12, 2024
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Replace enzyme with RTL functions. Refactor the tests accordingly.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
npm test ActivityTable.test.tsxADDITIONAL INFORMATION