Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(big-number-chart): number format is not applying to percentage number of the time comparison #27502

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

lilykuang
Copy link
Member

SUMMARY

This PR is a following up pr for this #27052 (comment) and fixes an issue where number formatting was not applied to percentage differences. A new formatting option for percentage differences has been added for this fix.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:
time-comparison

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.37%. Comparing base (a75bb76) to head (5e951d1).
Report is 1 commits behind head on master.

Files Patch % Lines
...Number/BigNumberPeriodOverPeriod/transformProps.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #27502   +/-   ##
=======================================
  Coverage   67.37%   67.37%           
=======================================
  Files        1909     1909           
  Lines       74694    74694           
  Branches     8326     8326           
=======================================
  Hits        50323    50323           
  Misses      22321    22321           
  Partials     2050     2050           
Flag Coverage Δ
javascript 57.22% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lilykuang lilykuang merged commit d2c9001 into master Mar 14, 2024
26 checks passed
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 18, 2024
…mber of the time comparison (apache#27502)

(cherry picked from commit d2c9001)
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 19, 2024
…mber of the time comparison (apache#27502)

(cherry picked from commit d2c9001)
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 22, 2024
…mber of the time comparison (apache#27502)

(cherry picked from commit d2c9001)
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 26, 2024
…mber of the time comparison (apache#27502)

(cherry picked from commit d2c9001)
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 26, 2024
…mber of the time comparison (apache#27502)

(cherry picked from commit d2c9001)
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 28, 2024
…mber of the time comparison (apache#27502)

(cherry picked from commit d2c9001)
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Apr 1, 2024
…mber of the time comparison (apache#27502)

(cherry picked from commit d2c9001)
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Apr 2, 2024
…mber of the time comparison (apache#27502)

(cherry picked from commit d2c9001)
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
@rusackas rusackas deleted the big-number-percentage-format branch April 16, 2024 16:52
betodealmeida pushed a commit that referenced this pull request Apr 25, 2024
…mber of the time comparison (#27502)

(cherry picked from commit d2c9001)
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
eschutho pushed a commit that referenced this pull request Jun 5, 2024
…mber of the time comparison (#27502)

(cherry picked from commit d2c9001)
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants