-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(big-number-chart): number format is not applying to percentage number of the time comparison #27502
Merged
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mber of the time comparison
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #27502 +/- ##
=======================================
Coverage 67.37% 67.37%
=======================================
Files 1909 1909
Lines 74694 74694
Branches 8326 8326
=======================================
Hits 50323 50323
Misses 22321 22321
Partials 2050 2050
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mistercrunch
approved these changes
Mar 14, 2024
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 18, 2024
…mber of the time comparison (apache#27502) (cherry picked from commit d2c9001)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 19, 2024
…mber of the time comparison (apache#27502) (cherry picked from commit d2c9001)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 22, 2024
…mber of the time comparison (apache#27502) (cherry picked from commit d2c9001)
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
…mber of the time comparison (apache#27502)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 26, 2024
…mber of the time comparison (apache#27502) (cherry picked from commit d2c9001)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 26, 2024
…mber of the time comparison (apache#27502) (cherry picked from commit d2c9001)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 28, 2024
…mber of the time comparison (apache#27502) (cherry picked from commit d2c9001)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 1, 2024
…mber of the time comparison (apache#27502) (cherry picked from commit d2c9001)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 2, 2024
…mber of the time comparison (apache#27502) (cherry picked from commit d2c9001)
EandrewJones
pushed a commit
to UMD-ARLIS/superset
that referenced
this pull request
Apr 5, 2024
…mber of the time comparison (apache#27502)
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
…mber of the time comparison (apache#27502)
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
…mber of the time comparison (apache#27502)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR is a following up pr for this #27052 (comment) and fixes an issue where number formatting was not applied to percentage differences. A new formatting option for percentage differences has been added for this fix.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION