Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(asf): removing google hosted analytics and fonts #27963

Merged
merged 3 commits into from
Apr 10, 2024
Merged

fix(asf): removing google hosted analytics and fonts #27963

merged 3 commits into from
Apr 10, 2024
+18 −14

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Apr 10, 2024 •
edited
Loading

SUMMARY

Per ASF Infra, GA/GTM and Google-hosted fonts are not allowed. This GA/GTM account is vestigial anyway (likely would've been disabled anyway since we certainly didn't upgrade to GA4), but let's just chop it out. The Google Fonts are now replaced with local files, which are under Apache 2.0 licensing. CSP access to these resources has been blocked.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas rusackas requested a review from villebro April 10, 2024 04:51
@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Apr 10, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 10, 2024
@rusackas rusackas changed the title fix(asf): removing google analytics fix(asf): removing google hosted analytics and fonts Apr 10, 2024
@rusackas rusackas merged commit 717a399 into master Apr 10, 2024
33 of 34 checks passed
@rusackas rusackas deleted the remove-google-from-docs branch April 10, 2024 14:19
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 15, 2024
@rusackas @EnxDev
fix(asf): removing google hosted analytics and fonts (apache#27963)
fb11b92
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@rusackas @qleroy
fix(asf): removing google hosted analytics and fonts (apache#27963)
7ae7c14
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@rusackas @jzhao62
fix(asf): removing google hosted analytics and fonts (apache#27963)
7f61f56
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@rusackas
fix(asf): removing google hosted analytics and fonts (apache#27963)
b43cfa7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@sfirke sfirke sfirke approved these changes

@villebro villebro Awaiting requested review from villebro

@mistercrunch mistercrunch Awaiting requested review from mistercrunch

Assignees
No one assigned
Labels
doc Namespace | Anything related to documentation preset-io size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rusackas @sfirke @michael-s-molina