Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Webpack dev-sever warnings): Add ignoreWarning to webpack config for @data-ui error #28232

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

rtexelm
Copy link
Member

@rtexelm rtexelm commented Apr 26, 2024

SUMMARY

Simply ignore the build warning related to @data-ui.
Because this warning arises from within the external module itself, which is no longer evolving, the idea is to ignore it until the module can be replaced by a living project to better fit the superset ecosystem.

Example warning:

WARNING in ./node_modules/@data-ui/shared/esm/enhancer/WithTooltip.js 3:60-78
export 'withTooltipPropTypes' (imported as 'vxTooltipPropTypes') was not found in '@vx/tooltip/build/tooltips/TooltipWithBounds' (possible exports: __esModule, default)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rtexelm rtexelm marked this pull request as ready for review April 26, 2024 08:07
@rtexelm rtexelm marked this pull request as draft April 26, 2024 08:07
@rtexelm rtexelm marked this pull request as ready for review April 26, 2024 16:14
@geido geido merged commit a38dc90 into apache:master Apr 30, 2024
54 checks passed
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants