Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql_parse): Ignore USE SQL keyword when determining SELECT statement #28279

Merged

Conversation

john-bodley
Copy link
Member

SUMMARY

The USE SQL keyword doesn't invalidate whether the parsed statement(s) represent a SELECT.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Added unit tests.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley force-pushed the john-bodley--fix-sql-parse-is-select branch from f521333 to 29f8e17 Compare May 2, 2024 17:03
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.04%. Comparing base (2e5f3ed) to head (29f8e17).
Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #28279      +/-   ##
==========================================
+ Coverage   60.49%   70.04%   +9.54%     
==========================================
  Files        1931     1933       +2     
  Lines       76241    76492     +251     
  Branches     8566     8566              
==========================================
+ Hits        46122    53577    +7455     
+ Misses      28015    20811    -7204     
  Partials     2104     2104              
Flag Coverage Δ
hive 49.21% <83.33%> (+0.05%) ⬆️
mysql 77.57% <83.33%> (?)
postgres 77.67% <83.33%> (?)
presto 53.84% <83.33%> (+0.03%) ⬆️
python 83.26% <100.00%> (+19.77%) ⬆️
sqlite 77.14% <83.33%> (?)
unit 57.72% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@john-bodley john-bodley merged commit 27952e7 into apache:master May 2, 2024
27 checks passed
@john-bodley john-bodley changed the title fix: Ignore USE SQL keyword when determining SELECT statement fix(sql_parse): Ignore USE SQL keyword when determining SELECT statement May 2, 2024
@michael-s-molina michael-s-molina added the v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch label May 2, 2024
michael-s-molina pushed a commit that referenced this pull request May 2, 2024
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label May 2, 2024
michael-s-molina pushed a commit that referenced this pull request May 2, 2024
dpgaspar pushed a commit to preset-io/superset that referenced this pull request May 6, 2024
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@mistercrunch mistercrunch added 🍒 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 24, 2024
irublev pushed a commit to HighviewPower/superset that referenced this pull request Oct 29, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 4.0.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants