-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sql_parse): Ignore USE SQL keyword when determining SELECT statement #28279
Merged
john-bodley
merged 1 commit into
apache:master
from
john-bodley:john-bodley--fix-sql-parse-is-select
May 2, 2024
Merged
fix(sql_parse): Ignore USE SQL keyword when determining SELECT statement #28279
john-bodley
merged 1 commit into
apache:master
from
john-bodley:john-bodley--fix-sql-parse-is-select
May 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
john-bodley--fix-sql-parse-is-select
branch
from
May 2, 2024 17:03
f521333
to
29f8e17
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #28279 +/- ##
==========================================
+ Coverage 60.49% 70.04% +9.54%
==========================================
Files 1931 1933 +2
Lines 76241 76492 +251
Branches 8566 8566
==========================================
+ Hits 46122 53577 +7455
+ Misses 28015 20811 -7204
Partials 2104 2104
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
betodealmeida
approved these changes
May 2, 2024
john-bodley
changed the title
fix: Ignore USE SQL keyword when determining SELECT statement
fix(sql_parse): Ignore USE SQL keyword when determining SELECT statement
May 2, 2024
michael-s-molina
added
the
v3.1
Label added by the release manager to track PRs to be included in the 3.1 branch
label
May 2, 2024
michael-s-molina
pushed a commit
that referenced
this pull request
May 2, 2024
(cherry picked from commit 27952e7)
michael-s-molina
added
the
v4.0
Label added by the release manager to track PRs to be included in the 4.0 branch
label
May 2, 2024
michael-s-molina
pushed a commit
that referenced
this pull request
May 2, 2024
(cherry picked from commit 27952e7)
dpgaspar
pushed a commit
to preset-io/superset
that referenced
this pull request
May 6, 2024
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
mistercrunch
added
🍒 4.0.2
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
labels
Jul 24, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The
USE
SQL keyword doesn't invalidate whether the parsed statement(s) represent a SELECT.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Added unit tests.
ADDITIONAL INFORMATION