chore(models): Adding encrypted field checks #28436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
It was recently discovered that the
SSHTunnel
model class was using theEncryptedField
type decorator directly as opposed to leveraging theEncryptedFieldFactory
. Although the current impl would allow for the proper encryption of fields in theSSHTunnel
model, anyone that's implemented a custom field viaEncryptedFieldFactory.create()
would have been broken as of the addition ofSSHTunnel
SSHTunnel
EncryptedType
fields were created viaEncryptedFieldFactory.create()