Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(models): Adding encrypted field checks #28436

Merged
merged 2 commits into from
May 13, 2024

Conversation

craig-rueda
Copy link
Member

SUMMARY

It was recently discovered that the SSHTunnel model class was using the EncryptedField type decorator directly as opposed to leveraging the EncryptedFieldFactory. Although the current impl would allow for the proper encryption of fields in the SSHTunnel model, anyone that's implemented a custom field via EncryptedFieldFactory.create() would have been broken as of the addition of SSHTunnel

  • Fixes SSHTunnel
  • Adds additional unit test that verifies all EncryptedType fields were created via EncryptedFieldFactory.create()

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.39%. Comparing base (76d897e) to head (b58d5d3).
Report is 87 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #28436       +/-   ##
===========================================
+ Coverage   60.48%   83.39%   +22.90%     
===========================================
  Files        1931      521     -1410     
  Lines       76236    37408    -38828     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31195    -14919     
+ Misses      28017     6213    -21804     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.03% <91.66%> (-0.13%) ⬇️
javascript ?
mysql 77.10% <100.00%> (?)
postgres 77.21% <100.00%> (?)
presto 53.60% <91.66%> (-0.21%) ⬇️
python 83.39% <100.00%> (+19.90%) ⬆️
sqlite 76.66% <100.00%> (?)
unit 58.76% <91.66%> (+1.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@craig-rueda craig-rueda merged commit 89dbb98 into apache:master May 13, 2024
33 of 34 checks passed
@craig-rueda craig-rueda deleted the craig/adding-enc-field-checks branch May 13, 2024 16:29
aehanno pushed a commit to kosmos-education/superset that referenced this pull request May 13, 2024
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants