-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove sl_ tables #28704
chore: remove sl_ tables #28704
Conversation
Adding @betodealmeida as a reviewer as he was the original author of said logic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the full history but this collection of models ('sl_.*') were created to support semantic layer, but the work to build on top of it never really started. This PR removes those models and the unfinished things build on top of it.
For context, SIP-68 (#14909) proposed to clean up out existing semantic layer, making relationships explicit and differentiating physical datasets from underlying tables.
Since changing the existing models was too big of an effort, the initial code created the new models, and performed a double-write to keep them in sync with the old models. The idea was to update the code to read from the new models, and then drop the double-write and the old models, but this never happened because still the effort was too much.
Could always revert or find inspiration here. But feels good to simplify the erd in the meantime |
SUMMARY
I don't know the full history but this collection of models ('sl_.*') were created to support semantic layer, but the work to build on top of it never really started. This PR removes those models and the unfinished things build on top of it.
I dug out this related SIP #17543
It includes: