Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove sl_ tables #28704

Merged
merged 9 commits into from
May 30, 2024
Merged

chore: remove sl_ tables #28704

merged 9 commits into from
May 30, 2024

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented May 24, 2024

SUMMARY

I don't know the full history but this collection of models ('sl_.*') were created to support semantic layer, but the work to build on top of it never really started. This PR removes those models and the unfinished things build on top of it.

I dug out this related SIP #17543

It includes:

  • sl_dataset_columns
  • sl_table_columns
  • sl_dataset_tables
  • sl_columns
  • sl_tables
  • sl_dataset_users
  • sl_datasets

@github-actions github-actions bot added the risk:db-migration PRs that require a DB migration label May 24, 2024
@mistercrunch mistercrunch marked this pull request as ready for review May 27, 2024 19:35
@mistercrunch mistercrunch requested a review from a team as a code owner May 27, 2024 19:35
@dosubot dosubot bot added the data Namespace | Anything related to data, including databases configurations, datasets, etc. label May 27, 2024
@john-bodley john-bodley requested a review from betodealmeida May 29, 2024 17:21
@john-bodley
Copy link
Member

Adding @betodealmeida as a reviewer as he was the original author of said logic.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the full history but this collection of models ('sl_.*') were created to support semantic layer, but the work to build on top of it never really started. This PR removes those models and the unfinished things build on top of it.

For context, SIP-68 (#14909) proposed to clean up out existing semantic layer, making relationships explicit and differentiating physical datasets from underlying tables.

Since changing the existing models was too big of an effort, the initial code created the new models, and performed a double-write to keep them in sync with the old models. The idea was to update the code to read from the new models, and then drop the double-write and the old models, but this never happened because still the effort was too much.

@mistercrunch
Copy link
Member Author

Could always revert or find inspiration here. But feels good to simplify the erd in the meantime

@mistercrunch mistercrunch merged commit 7dd28a9 into master May 30, 2024
31 checks passed
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
@rusackas rusackas deleted the rm_sl branch September 27, 2024 21:04
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels data Namespace | Anything related to data, including databases configurations, datasets, etc. preset-io risk:db-migration PRs that require a DB migration size/XL 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants