Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(explore): Drill to detail truncates int64 IDs #29081

Merged
merged 1 commit into from
Jun 5, 2024
Merged

fix(explore): Drill to detail truncates int64 IDs #29081

merged 1 commit into from
Jun 5, 2024

Conversation

justinpark
Copy link
Member

SUMMARY

This commit fixes the missing json-bigint parseMethod on dril-to-detail view request.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screenshot 2024-06-04 at 5 18 24 PM

After:

Screenshot 2024-06-04 at 5 18 00 PM

TESTING INSTRUCTIONS

Create a chart including int64 value and then click "drill to detail" in the dashboard

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@justinpark justinpark merged commit dabb4e0 into apache:master Jun 5, 2024
33 of 34 checks passed
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Jun 5, 2024
michael-s-molina pushed a commit that referenced this pull request Jun 5, 2024
@justinpark @michael-s-molina
fix(explore): Drill to detail truncates int64 IDs (#29081)
c9a6537 
(cherry picked from commit dabb4e0)
@mistercrunch mistercrunch added 🍒 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 24, 2024
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@justinpark @eschutho
fix(explore): Drill to detail truncates int64 IDs (#29081)
1e04adc
@dosubot dosubot bot mentioned this pull request Oct 15, 2024
Open
3 tasks
irublev pushed a commit to HighviewPower/superset that referenced this pull request Oct 29, 2024
@justinpark @michael-s-molina
fix(explore): Drill to detail truncates int64 IDs (apache#29081)
aff36e8 
(cherry picked from commit 16a0002)
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@justinpark
fix(explore): Drill to detail truncates int64 IDs (apache#29081)
d272357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@john-bodley john-bodley Awaiting requested review from john-bodley

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:drill-to-detail size/XS v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 4.0.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinpark @michael-s-molina @mistercrunch