feat: add new SQLLAB_FORCE_RUN_ASYNC feature flag #29231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
global:async-query
|
@mistercrunch could you provide more details with regards to the motivation for this change? It likely introduces a degraded UX as admins likely could be misinformed that a given database is running in sync mode whereas in actuality (when the feature flag is enabled) the database is using async. |
|
The requirement is we want the optionality to enforce this for some of our customers at Preset, but I get your point and I agree that I should probably disable the UI element in the database connection form. |
When setting up a celery backend to run asynchronous workloads, the administrator can set any given database connection to use (or not use) that backend. This PR introduced a new feature flag SQLLAB_FORCE_RUN_ASYNC (False by default) that disregards the database configuration, and forces SQL Lab to use the async backend. NOTE: superset/sqllab/sqllab_execution_context.py didn't have unit tests so I wrote started a new module to run basic tests around it.
mistercrunch
force-pushed
the
ff_force_async
branch
from
29ee273
to
4cdf122
Compare
|
@john-bodley I added frontend cues -> |
mistercrunch
requested review from
villebro,
geido,
eschutho,
rusackas,
nytai,
craig-rueda,
john-bodley,
kgabryje and
dpgaspar
as code owners
github-actions
bot
added
the
github_actions
mistercrunch
force-pushed
the
ff_force_async
branch
from
63f81ed
to
9538b75
Compare
github-actions
bot
removed
the
github_actions
geido
reviewed
Jun 20, 2024
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
geido
approved these changes
Jun 20, 2024
|
No worries, a quick --fix took care of it |
eschutho
pushed a commit
that referenced
this pull request
Jul 24, 2024
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up a celery backend to run asynchronous workloads, the administrator can set any given database connection to use (or not use) that backend. This PR introduced a new feature flag SQLLAB_FORCE_RUN_ASYNC (False by default) that disregards the database configuration, and forces SQL Lab to use the async backend.
NOTE: superset/sqllab/sqllab_execution_context.py didn't have unit tests so I wrote started a new module to run basic tests around it.