Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): Fix MySQL logic #29356

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Jun 25, 2024

SUMMARY

Whilst spelunking through the tests, I realized that there was quirky logic for handle some atypical MySQL behavior. This seems to no longer be required, most probably as a byproduct of #28628.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.75%. Comparing base (76d897e) to head (f736fb3).
Report is 358 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29356       +/-   ##
===========================================
+ Coverage   60.48%   83.75%   +23.26%     
===========================================
  Files        1931      518     -1413     
  Lines       76236    37624    -38612     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31511    -14603     
+ Misses      28017     6113    -21904     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.90% <ø> (-0.26%) ⬇️
javascript ?
mysql 77.32% <ø> (?)
postgres 77.40% <ø> (?)
presto 53.51% <ø> (-0.30%) ⬇️
python 83.75% <ø> (+20.26%) ⬆️
sqlite 76.85% <ø> (?)
unit 59.20% <ø> (+1.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@john-bodley john-bodley force-pushed the john-bodley--fix-mysql-tests branch 2 times, most recently from 53de29a to 93c8d2e Compare June 25, 2024 07:07
@john-bodley john-bodley marked this pull request as ready for review June 25, 2024 07:30
@john-bodley john-bodley force-pushed the john-bodley--fix-mysql-tests branch 3 times, most recently from 5d7ea2b to 05cd80f Compare June 25, 2024 15:58
@john-bodley john-bodley merged commit f9f70e3 into apache:master Jun 25, 2024
37 checks passed
@john-bodley john-bodley deleted the john-bodley--fix-mysql-tests branch June 25, 2024 17:20
eschutho pushed a commit that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants