Bug Fix: Handling pandas ExtensionDtypes #2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianmenges
force-pushed
the
ExtensionDtypes
branch
from
f6d96c2
to
82c08da
Compare
fabianmenges
force-pushed
the
ExtensionDtypes
branch
2 times, most recently
from
f471a28
to
93199c7
Compare
|
Will this one be merged or should we do a custom patch? It's causing some issues for us. |
fabianmenges
force-pushed
the
ExtensionDtypes
branch
from
93199c7
to
14ff3dd
Compare
2 similar comments
This was referenced Sep 21, 2017
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas ExtensionDtypes are not handled correctly in SQL Lab.
If a SQL column is of type TIMESTAMP and supports timezones, pandas returns an object of type
DatetimeTZDtypehttps://github.com/pandas-dev/pandas/blob/v0.20.2/pandas/io/sql.py#L911DatetimeTZDtypeis a np.dtype duck-typed class but not a real numpy dtype.