Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-add missing code from PR #28132 #29446

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

sadpandajoe
Copy link
Member

SUMMARY

Looks like when we did the table with time comparison, there was a bug fix in the feature branch that was not in there during the merge. This is to add back that code from #28132 to fix the same bug again.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@yousoph
Copy link
Member

yousoph commented Jul 1, 2024

/testenv up FLAG_CHART_PLUGINS_EXPERIMENTAL=True

@sadpandajoe sadpandajoe marked this pull request as ready for review July 1, 2024 18:11
@dosubot dosubot bot added the explore Namespace | Anything related to Explore label Jul 1, 2024
Copy link
Contributor

github-actions bot commented Jul 1, 2024

@yousoph Ephemeral environment spinning up at http://34.208.231.210:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@sadpandajoe sadpandajoe changed the title fix: re-add missing code from 28132 fix: re-add missing code from PR #28132 Jul 2, 2024
Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yousoph yousoph merged commit fb1f2c4 into apache:master Jul 2, 2024
63 checks passed
@yousoph yousoph deleted the joe/fix-render-operator branch July 2, 2024 23:58
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Ephemeral environment shutdown and build artifacts deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
explore Namespace | Anything related to Explore size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants