Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Tag): Upgrade Tag and TagsList to Ant Design 5 #29593

Merged
merged 1 commit into from
Jul 17, 2024
Merged

refactor(Tag): Upgrade Tag and TagsList to Ant Design 5 #29593

merged 1 commit into from
Jul 17, 2024
+51 −5

Conversation

geido
Copy link
Member

@geido geido commented Jul 15, 2024

SUMMARY

Please refer to the Superset Improvement Proposal #29268

BEFORE

346635692-3b7159f7-edf1-40e5-afdb-eb944fdd509d

AFTER

346635367-addcb129-4df8-4e49-9927-eafbd7975ed4

TESTING INSTRUCTIONS

  1. Verify the usage of the Tag throughout the application.
  2. Ensure no visual or behavioral changes have been introduced.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the change:frontend Requires changing the frontend label Jul 15, 2024
@michael-s-molina michael-s-molina added the review:checkpoint Last PR reviewed during the daily review standup label Jul 15, 2024
rusackas
rusackas reviewed Jul 16, 2024
View reviewed changes
superset-frontend/src/components/Tags/Tag.stories.tsx
component: Tag,
};
export const InteractiveTag = (args: TagType) => (
<AntdThemeProvider>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #29545 I add the theme provider globally, so that we don't need to do it in every story :)

rusackas
rusackas reviewed Jul 16, 2024
View reviewed changes
superset-frontend/src/components/Tags/TagsList.stories.tsx
editable,
maxTags,
}: TagsListProps) => (
<AntdThemeProvider>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto here, we can remove this provider soon...

@michael-s-molina michael-s-molina removed the review:checkpoint Last PR reviewed during the daily review standup label Jul 16, 2024
@geido geido merged commit c0d46eb into master Jul 17, 2024
39 checks passed
@rusackas rusackas deleted the geido/chore/antd5-tagslist branch July 17, 2024 21:48
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@geido @eschutho
refactor(Tag): Upgrade Tag and TagsList to Ant Design 5 (#29593)
992b2dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas left review comments

@rtexelm rtexelm rtexelm approved these changes

Assignees
No one assigned
Labels
change:frontend Requires changing the frontend frontend:refactor:antd5 size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@geido @rusackas @rtexelm @michael-s-molina