Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clear redux localStorage on logout #29602

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Conversation

geido
Copy link
Member

@geido geido commented Jul 16, 2024

SUMMARY

When logging out the redux key in localStorage was not cleared up causing some data to spill over different users. This PR clears out the redux localStorage key on logout.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

  1. Logout
  2. Login with a different user
  3. Make sure no information are spilling over

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido requested a review from dpgaspar July 16, 2024 14:24
@dosubot dosubot bot added the authentication Related to authentication label Jul 16, 2024
@geido geido merged commit 245e198 into master Jul 17, 2024
35 of 37 checks passed
@rusackas rusackas deleted the geido/chore/clear-sql-sqlab branch July 17, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication Related to authentication size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants