Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend/docker, ci): fix borked Docker build due to Lerna v8 uplift #29725

Merged
merged 2 commits into from
Jul 30, 2024
Merged

fix(frontend/docker, ci): fix borked Docker build due to Lerna v8 uplift #29725

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5c53bf
fix(docker): install optional `@nx` dep for Lerna v8+
hainenber Jul 27, 2024
75d4874
chore(build): uplift `prop-types` to 15.8.1
hainenber Jul 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/docker-frontend.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ fi
if [ "$BUILD_SUPERSET_FRONTEND_IN_DOCKER" = "true" ]; then
cd /app/superset-frontend
npm install -f --no-optional --global webpack webpack-cli
npm install -f --no-optional
npm install -f
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mistercrunch I saw this flag was added previously but unsure the context. I believe there's a historical reason for it? 👀

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some git archeology and it looks like --no-optional goes back to #10766 (2020) and there's not a clear explanation. I vote going vanilla and doing a very simple npm install instead of those 2 lines. Webpack packages should install as its just a devDependencies, and they'll install normally as long as we don't specify --production, which we don't want to do here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tagging @eschutho as I believe she ran in an issue similar to the one you're fixing here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... looks like @craig-rueda added that a looooong time ago. I'm not sure if there are any consequences to its removal ¯\_(ツ)_/¯

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eek... duplicated effort. That's what I get for revisiting an open tab without refreshing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rusackas I really think it's ok to remove this --no-optional as it's non-standard and in this context would only apply BUILD_SUPERSET_FRONTEND_IN_DOCKER" = "true" which really should align with other build context (if you're running a dev env outside docker for instance).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm. I'll remove the pinned optional dependencies in my pr.


echo "Running frontend"
npm run dev
Expand Down