-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove --no-optional from docker-compose build #29779
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
dependencies:npm
install:docker
Installation - docker container
labels
Jul 30, 2024
rusackas
reviewed
Jul 30, 2024
mistercrunch
force-pushed
the
no_no_optional
branch
from
July 30, 2024 18:27
def959b
to
eeb26c5
Compare
9 tasks
mistercrunch
commented
Jul 30, 2024
cd /app/superset-frontend | ||
npm install -f --no-optional --global webpack webpack-cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not needed
rusackas
approved these changes
Jul 30, 2024
@supersetbot label 4.1 |
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Jul 30, 2024
(cherry picked from commit 6bf8596)
github-actions
bot
added
the
v4.1
Label added by the release manager to track PRs to be included in the 4.1 branch
label
Jul 30, 2024
@supersetbot unlabel 4.1 |
github-actions
bot
removed
the
v4.1
Label added by the release manager to track PRs to be included in the 4.1 branch
label
Aug 1, 2024
This was referenced Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unusual artifact from local docker-compose setup, using vanilla
npm install