Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove --no-optional from docker-compose build #29779

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Conversation

mistercrunch
Copy link
Member

Remove unusual artifact from local docker-compose setup, using vanilla npm install

@dosubot dosubot bot added dependencies:npm install:docker Installation - docker container labels Jul 30, 2024
cd /app/superset-frontend
npm install -f --no-optional --global webpack webpack-cli
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not needed

@mistercrunch mistercrunch merged commit 6bf8596 into master Jul 30, 2024
33 checks passed
@rusackas rusackas deleted the no_no_optional branch July 30, 2024 21:46
@sadpandajoe
Copy link
Member

@supersetbot label 4.1

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Jul 30, 2024
@github-actions github-actions bot added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Jul 30, 2024
@sadpandajoe
Copy link
Member

@supersetbot unlabel 4.1

@github-actions github-actions bot removed the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
install:docker Installation - docker container size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants