fix: Error when downgrading add_catalog_perm_to_tables migration #29906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
risk:breaking-change
michael-s-molina
removed
the
risk:breaking-change
betodealmeida
approved these changes
Aug 9, 2024
| @@ -48,6 +48,6 @@ def upgrade(): | |||
|
|
|||
|
|
|||
| def downgrade(): | |||
| downgrade_catalog_perms(engines={"postgresql"}) | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29906 +/- ##
===========================================
+ Coverage 60.48% 83.72% +23.23%
===========================================
Files 1931 527 -1404
Lines 76236 38043 -38193
Branches 8568 0 -8568
===========================================
- Hits 46114 31851 -14263
+ Misses 28017 6192 -21825
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mistercrunch
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
double-stamping it, thank you @michael-s-molina for tackling this!
|
@supersetbot label 4.1 |
github-actions
bot
added
the
v4.1
sadpandajoe
pushed a commit
that referenced
this pull request
Aug 13, 2024
) (cherry picked from commit fb7f508)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes a error when downgrading revision
58d051681a3b. The previous code was invokingdowngrade_catalog_permsafter dropping thecatalog_permcolumn which is used by that function, generating an error:This PR also rewrites revision
5f57af97bc3fto remove duplicated code.TESTING INSTRUCTIONS
Check both upgrade and downgrade operations for each migration.
ADDITIONAL INFORMATION