Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add imports back to celery file #29921

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

sadpandajoe
Copy link
Member

SUMMARY

Fixes issue #29708. When we were adding ruff in #28158, I'm guessing it was removed as these were unused imports.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.69%. Comparing base (76d897e) to head (5ab7fb2).
Report is 581 commits behind head on master.

Files Patch % Lines
superset/tasks/celery_app.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29921       +/-   ##
===========================================
+ Coverage   60.48%   83.69%   +23.21%     
===========================================
  Files        1931      527     -1404     
  Lines       76236    38053    -38183     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31850    -14264     
+ Misses      28017     6203    -21814     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.02% <0.00%> (-0.15%) ⬇️
javascript ?
mysql 76.78% <0.00%> (?)
postgres 76.85% <0.00%> (?)
presto 53.56% <0.00%> (-0.24%) ⬇️
python 83.69% <0.00%> (+20.21%) ⬆️
sqlite 76.34% <0.00%> (?)
unit 60.36% <0.00%> (+2.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I restarted the flaky MySQL IT which had failed

@rusackas rusackas merged commit 9f5eb89 into apache:master Aug 12, 2024
38 of 39 checks passed
@rusackas rusackas deleted the joe/add-imports-back-to-celery branch August 12, 2024 22:21
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Aug 12, 2024
sadpandajoe added a commit that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants