fix: unable to disallow csv upload on header menu #30271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadpandajoe
added
the
v4.1
michael-s-molina
approved these changes
Sep 17, 2024
sadpandajoe
pushed a commit
that referenced
this pull request
Sep 18, 2024
(cherry picked from commit cd8b567)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30260
SUMMARY
In the #28192, the CSV menu was changed from a page URL to a modal popup, which led to an issue where the popup could be triggered even when the menu was in a disabled state.
This commit addresses the problem by passing the disabled property to the menu, making it impossible to click.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--csv-upload-disabled.mov
After:
after--csv-upload-disabled.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION