Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(GAQ): [Merge 5.0] Breaking change: Remove GLOBAL_ASYNC_QUERIES_REDIS_CONFIG #30284

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nsivarajan
Copy link
Contributor

SUMMARY

This PR follows up on #29912 and removes the deprecated GLOBAL_ASYNC_QUERIES_REDIS_CONFIG configuration in favor of the new GLOBAL_ASYNC_QUERIES_CACHE_BACKEND configuration. It is intended to be merged into version 5.0.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.75%. Comparing base (76d897e) to head (720a02f).
Report is 738 commits behind head on master.

Files with missing lines Patch % Lines
superset/async_events/async_query_manager.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #30284       +/-   ##
===========================================
+ Coverage   60.48%   83.75%   +23.26%     
===========================================
  Files        1931      534     -1397     
  Lines       76236    38544    -37692     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32282    -13832     
+ Misses      28017     6262    -21755     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.94% <75.00%> (-0.23%) ⬇️
javascript ?
mysql 76.74% <75.00%> (?)
postgres 76.81% <75.00%> (?)
presto 53.44% <75.00%> (-0.37%) ⬇️
python 83.75% <75.00%> (+20.26%) ⬆️
sqlite 76.26% <75.00%> (?)
unit 60.51% <75.00%> (+2.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nsivarajan nsivarajan marked this pull request as ready for review September 15, 2024 07:04
@dosubot dosubot bot added change:backend Requires changing the backend risk:breaking-change Issues or PRs that will introduce breaking changes labels Sep 15, 2024
@rusackas
Copy link
Member

I think @villebro has the most context here, so I'll request his review, and re-start our flaky E2E test while I'm at it.

@rusackas rusackas added the review:checkpoint Last PR reviewed during the daily review standup label Sep 16, 2024
@michael-s-molina michael-s-molina removed the review:checkpoint Last PR reviewed during the daily review standup label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:backend Requires changing the backend risk:breaking-change Issues or PRs that will introduce breaking changes size/M
Projects
Status: Proposals - Not proposed for consensus
Development

Successfully merging this pull request may close these issues.

4 participants