Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(legacy-plugin-chart-country-map)Fix the territories of Karelia and Murmansk(#30326) #30328

Closed
wants to merge 1 commit into from

Conversation

SBIN2010
Copy link

@SBIN2010 SBIN2010 commented Sep 18, 2024

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE
image

AFTER
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the viz:charts:geojson Related to the deck.gl Geojson label Sep 18, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make any geojson changes via the Jupyter notebook (it's the .ipynb file in the repo). This notebook will overwrite any/all geojson files, so the changes as you've made them here are ephemeral.

Also, our data is gathered via NaturalEarth, so I would advise filing an issue with them (on their repo or otherwise) to fix this upstream from Superset.

@SBIN2010
Copy link
Author

rusackas

I don't think it's a good idea to add such changes to the Jupyter notebook. Since I found this flaw in the NaturalEarth database, and have already created an issue to fix it. (nvkelso/natural-earth-vector#929)
Therefore, when the corrections appear in NaturalEarth, then it will be correct in Superset.

@SBIN2010 SBIN2010 closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugins size/XXL viz:charts:geojson Related to the deck.gl Geojson
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants