Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add link to Superset when report error #30576

Merged
merged 1 commit into from
Oct 21, 2024
Merged

chore: add link to Superset when report error #30576

merged 1 commit into from
Oct 21, 2024

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Oct 10, 2024 •
edited
Loading

SUMMARY

Adds a link to the dashboard or chart for the report/alert when there is an error so that the root cause can more easily be found by accessing the asset that has the error. Also updated the error message to be more friendly.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2024-10-17 at 1 49 34 PM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho force-pushed the elizabeth/add-footer-error-report branch from cd9c4c7 to 599826d Compare October 10, 2024 21:56
@eschutho eschutho force-pushed the elizabeth/add-footer-error-report branch from 599826d to 1333dee Compare October 17, 2024 20:15
@eschutho eschutho force-pushed the elizabeth/add-footer-error-report branch from 1333dee to 26cfce7 Compare October 17, 2024 20:47
@eschutho eschutho marked this pull request as ready for review October 17, 2024 20:52
@dosubot dosubot bot added the alert-reports Namespace | Anything related to the Alert & Reports feature label Oct 17, 2024
betodealmeida
betodealmeida approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@eschutho eschutho merged commit 4d5f70c into master Oct 21, 2024
43 of 61 checks passed
mistercrunch pushed a commit that referenced this pull request Oct 28, 2024
@eschutho @mistercrunch
chore: add link to Superset when report error (#30576)
0f9c935
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Nov 13, 2024
sadpandajoe pushed a commit that referenced this pull request Nov 13, 2024
@eschutho @sadpandajoe
chore: add link to Superset when report error (#30576)
af44b14 
(cherry picked from commit 4d5f70c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

Assignees
No one assigned
Labels
alert-reports Namespace | Anything related to the Alert & Reports feature preset-io size/S v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eschutho @betodealmeida @sadpandajoe @michael-s-molina