Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set correct amount of steps to avoid confusing logs while loading examples #30606

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

deathstrokedarksky
Copy link
Contributor

Summary

This pull request addresses an issue with the logging behavior in the docker/docker-init.sh script when loading examples in Apache Superset. The change ensures that the number of steps logged during the initialization process reflects whether example data should be loaded, thus preventing confusion in the logs. It was actually confusing in my case when I first ran superset in docker in different modes.

Changes Made

  • Modified the STEP_CNT variable initialization logic in the docker/docker-init.sh script.
  • Added a conditional check to set STEP_CNT properly.

Testing Instructions

  1. Verify that the environment variable SUPSET_LOAD_EXAMPLES can be set to either "yes" or "no".
  2. Deploy the superset environment in different modes and observe the logs.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@michael-s-molina michael-s-molina changed the title Set proper amount of steps to avoid confusing logs while examples fix: Set proper amount of steps to avoid confusing logs while loading examples Oct 15, 2024
@michael-s-molina michael-s-molina changed the title fix: Set proper amount of steps to avoid confusing logs while loading examples fix: Set correct amount of steps to avoid confusing logs while loading examples Oct 15, 2024
@michael-s-molina michael-s-molina changed the title fix: Set correct amount of steps to avoid confusing logs while loading examples fix: Set correct amount of steps to avoid confusing logs while loading examples Oct 15, 2024
@michael-s-molina michael-s-molina merged commit d6b2e86 into apache:master Oct 15, 2024
37 of 41 checks passed
@michael-s-molina
Copy link
Member

Thank you @deathstrokedarksky!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants