Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Avatar): Migrate Avatar to Ant Design 5 #30740

Merged
merged 5 commits into from
Nov 13, 2024
Merged

refactor(Avatar): Migrate Avatar to Ant Design 5 #30740

merged 5 commits into from
Nov 13, 2024

Conversation

msyavuz
Copy link
Contributor

@msyavuz msyavuz commented Oct 29, 2024

SUMMARY

Migrate Avatar to Ant Design 5 while maintaining visual consistency.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
avatar-before
After:
avatar-after

TESTING INSTRUCTIONS

Test if there are visual changes in-app or storybook.

ADDITIONAL INFORMATION

  • Has associated issue: Fixes Ant Design 5: Upgrade Avatar component #30726
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@msyavuz msyavuz force-pushed the msyavuz/refactor/migrate-avatar branch from 35b5f93 to 34f4d71 Compare October 30, 2024 11:23
@msyavuz msyavuz marked this pull request as ready for review October 30, 2024 11:46
@dosubot dosubot bot added change:frontend Requires changing the frontend frontend:refactor:antd5 labels Oct 30, 2024
@geido
Copy link
Member

geido commented Oct 30, 2024

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://18.236.160.116:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@geido
Copy link
Member

geido commented Oct 31, 2024

Thanks for the PR @msyavuz. I noticed that something is off when you have multiple avatars. The number is misaligned and hovering seems also to be broken (the arrow shows as a dark square). This is on Chrome. It does not happen on master.

Screenshot 2024-10-31 at 15 46 03

Screenshot 2024-10-31 at 15 46 13

@geido geido added preset:bounty Issues that have been selected by Preset and have a bounty attached. hold! On hold labels Oct 31, 2024
@msyavuz
Copy link
Contributor Author

msyavuz commented Nov 4, 2024

@geido Issue was importing from antd-v5/lib. I fixed it but we should be careful with other components in the future as well.

@geido geido removed the hold! On hold label Nov 13, 2024
geido
geido approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@geido geido merged commit 6e665c3 into apache:master Nov 13, 2024
34 of 35 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido approved these changes

@rusackas rusackas Awaiting requested review from rusackas

Assignees
No one assigned
Labels
change:frontend Requires changing the frontend frontend:refactor:antd5 preset:bounty Issues that have been selected by Preset and have a bounty attached. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ant Design 5: Upgrade Avatar component
3 participants
@msyavuz @geido @michael-s-molina