Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[line chart] add 'min_periods' control related to rolling windows #3397

Merged
merged 2 commits into from
Aug 30, 2017

Conversation

mistercrunch
Copy link
Member

This new control ties in directly with Pandas min_periods:
http://pandas.pydata.org/pandas-docs/version/0.17.0/generated/pandas.rolling_mean.html
screen shot 2017-08-30 at 11 47 02 am

@jasonkb
Copy link

jasonkb commented Aug 30, 2017

@mistercrunch LGTM Thank you! I wonder if there is a nice way to set min periods to periods by default? Or is it also common to not want that?

@mistercrunch
Copy link
Member Author

It seems like a better default, though it could change existing assets which is not ideal. For sum it's a much better default, for average it's many may want to see it converge... Leaving as is for now.

@jasonkb
Copy link

jasonkb commented Aug 30, 2017

Kk makes sense!

@coveralls
Copy link

coveralls commented Aug 30, 2017

Coverage Status

Coverage decreased (-0.04%) to 68.64% when pulling 5d25479 on mistercrunch:min_period into 1fd08a5 on apache:master.

@coveralls
Copy link

coveralls commented Aug 30, 2017

Coverage Status

Coverage decreased (-0.1%) to 68.582% when pulling a972dd2 on mistercrunch:min_period into 1fd08a5 on apache:master.

@mistercrunch mistercrunch merged commit ac5da46 into apache:master Aug 30, 2017
@mistercrunch mistercrunch deleted the min_period branch August 30, 2017 20:32
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants