Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding hook for CSRF exempting flask views. #3435

Merged
merged 1 commit into from
Sep 15, 2017

Conversation

fabianmenges
Copy link
Contributor

This is useful if you have a postback authentication scheme (e.g. oauth) that is not supported by flask-appbulider.

@coveralls
Copy link

coveralls commented Sep 8, 2017

Coverage Status

Coverage decreased (-0.03%) to 69.087% when pulling 646b71600a11a3c027415141da92d572301bb02c on tc-dc:fmenges/CSRF_exempt_views into 3dfdde1 on apache:master.

@@ -65,6 +65,9 @@

# Flask-WTF flag for CSRF
WTF_CSRF_ENABLED = True
# Add endpoints that should be exempt from CSRF protection

# WTF_CSRF_EXEMPT_LIST = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need it commented

Copy link
Contributor

@xrmx xrmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation too, please.

@coveralls
Copy link

coveralls commented Sep 12, 2017

Coverage Status

Coverage decreased (-0.03%) to 69.091% when pulling 591efad on tc-dc:fmenges/CSRF_exempt_views into 147c12d on apache:master.

@fabianmenges
Copy link
Contributor Author

I don't think there is much to unit test here.

@mistercrunch mistercrunch merged commit e22aecb into apache:master Sep 15, 2017
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants