Adding hook for external password store for databases #3436
Conversation
|
Coverage decreased (-0.001%) to 69.117% when pulling c33355c1997dad1c2e172b8a99ec3b8f13e48a2c on tc-dc:fmenges/external_password_store into 3dfdde1 on apache:master. |
| @@ -60,6 +60,15 @@ | |||
| # SQLALCHEMY_DATABASE_URI = 'mysql://myapp@localhost/myapp' | |||
| # SQLALCHEMY_DATABASE_URI = 'postgresql://root:password@localhost/myapp' | |||
|
|
|||
| # In order to hook up a custom password store for all SQLACHEMY connections | |||
There was a problem hiding this comment.
Better add documentation to documentation instead of config files. You can just set
SQLALCHEMY_CUSTOM_PASSWORD_STORE = False here
There was a problem hiding this comment.
Agreed with @xrmx , please add a note in installation.rst (and rebase)
fabianmenges
force-pushed
the
fmenges/external_password_store
branch
2 times, most recently
from
f4140a0
to
b49827d
Compare
|
Coverage decreased (-0.001%) to 69.117% when pulling b49827d90e4bee62a7abe14a8975e6cbed24c2be on tc-dc:fmenges/external_password_store into 147c12d on apache:master. |
|
Coverage decreased (-0.001%) to 69.117% when pulling b49827d90e4bee62a7abe14a8975e6cbed24c2be on tc-dc:fmenges/external_password_store into 147c12d on apache:master. |
fabianmenges
force-pushed
the
fmenges/external_password_store
branch
from
b49827d
to
95a52d3
Compare
|
Coverage decreased (-0.09%) to 69.027% when pulling 95a52d3b3b5e30dc943cf015cf3b0e033e6d7ec9 on tc-dc:fmenges/external_password_store into 8223729 on apache:master. |
fabianmenges
force-pushed
the
fmenges/external_password_store
branch
from
95a52d3
to
133d3d3
Compare
2 similar comments
|
|
||
| database.custom_password_store = custom_password_store | ||
| conn = sqla.engine.url.make_url(database.sqlalchemy_uri_decrypted) | ||
| if conn_pre.password: |
There was a problem hiding this comment.
Sqlite does not support passwords, so this test would fail otherwise.
mistercrunch
added
🏷️ bot
This allows you to write a plugin for an external password store for you sql passwords.
My employer has a strict policy that all credentials are managed by a single system, this now allowing us to store SQL passwords inside of the Superset meta-database .