[heatmap] numerous improvements #3456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mistercrunch
commented
Sep 13, 2017
mistercrunch
commented
- flexibility as to how to sort X and Y axis (alpha/value, desc/asc)
- option to show a legend
- fixed margins, maximize real estate
- allowed users to define bounds
* flexibility as to how to sort X and Y axis (alpha/value, desc/asc) * option to show a legend * fixed margins, maximize real estate * allowed users to define bounds
superset/viz.py
Outdated
| max_ = bounds[1] | ||
| else: | ||
| max_ = v.max() | ||
| df['perc'] = (v - min_) / (max_ - min_) |
There was a problem hiding this comment.
Possible divide by 0?
|
LGTM! |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.