Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customized sort column at time series chart #4304

Closed
wants to merge 5 commits into from

Conversation

UpTownCat
Copy link

I am sorry about previous pull request modified sql directly, I have digged the code and change the order column before it generates sql when chart is time series chart.

@mistercrunch
Copy link
Member

I don't understand what this fixes. Can you explain the difference between the before/after?

@UpTownCat
Copy link
Author

When I need to export time series chart to csv file, I found I could not sort by specified column from metrics. The default sort column is the first column at metrics, even if I selected another column.

So I change some code and accept the specified sort column from front end. After that, the default sort column is date column if user does not specified sort column, and user can specified sort column whatever he wants from metrics when he needs to export csv file

@kristw kristw added the enhancement:request Enhancement request submitted by anyone from the community label Jan 23, 2019
@kristw kristw added inactive Inactive for >= 30 days need:rebase Requires rebasing on top of current master labels Mar 20, 2019
@kristw kristw closed this Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:request Enhancement request submitted by anyone from the community inactive Inactive for >= 30 days need:rebase Requires rebasing on top of current master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants