fixing Issue #4335 - Not quoting column name when doing a time series #4343
Conversation
| @@ -113,7 +113,7 @@ def get_time_filter(self, start_dttm, end_dttm): | |||
| def get_timestamp_expression(self, time_grain): | |||
| """Getting the time component of the query""" | |||
| expr = self.expression or self.column_name | |||
| if not self.expression and not time_grain: | |||
| if not self.expression and (not time_grain or time_grain == u'Time Column'): | |||
There was a problem hiding this comment.
u'foo' isn't python3 compatible I think. I'm surprised that label-looking Time Column is a possible value here, somehow it should be time_column or None instead.
There was a problem hiding this comment.
Yea, it's u'Time Column' not None or something else
There was a problem hiding this comment.
I looked up the python 3 docs, the u'foo' is valid in python 3
|
hi any solution regarding this? During I'm evaluate superset via my sample mysql data warehouse, notice that lot of charts cannot be generate due to no backquote column name. Example like Sum(Sales Amount) cause sql error. |
|
@kstan79 I think this is fixed on master, can you confirm? |
kristw
added
!deprecated-label:bug
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Fixed issue as discussed in Issue #4335 comments.