Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix the arguement order for security function #4745

Closed
wants to merge 1 commit into from

Conversation

feng-tao
Copy link
Member

@feng-tao feng-tao commented Apr 3, 2018

Minor bug fix: the perm and view_menu seems to be in the wrong order.

cc @mistercrunch @hughhhh

@codecov-io
Copy link

Codecov Report

Merging #4745 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4745   +/-   ##
=======================================
  Coverage   72.38%   72.38%           
=======================================
  Files         205      205           
  Lines       15374    15374           
  Branches     1182     1182           
=======================================
  Hits        11128    11128           
  Misses       4243     4243           
  Partials        3        3
Impacted Files Coverage Δ
superset/security.py 74.21% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6fe11f...a75d56e. Read the comment docs.

@xrmx
Copy link
Contributor

xrmx commented Apr 3, 2018

Opportunity to add a test?

@mistercrunch
Copy link
Member

I'm wondering if the perms are reversed here somehow, which would make this a backward incompatible change...

@feng-tao feng-tao force-pushed the tfeng_fix_security branch from a75d56e to e0dda3c Compare April 3, 2018 21:40
@feng-tao
Copy link
Member Author

feng-tao commented Apr 3, 2018

@xrmx, I could add a test if it is an issue. I hope I am not misunderstand the code...

@feng-tao feng-tao closed this Apr 3, 2018
@feng-tao feng-tao reopened this Apr 3, 2018
@feng-tao feng-tao closed this Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants