[READY] [feature] Added dashboard read only with new Rho role

[datinho]

I needed a user who could only access the read-only dashboards, so I've added a new built-in role Rho (ρ) as logged user but less powerful than Gamma.
As Gamma user this role need a complementary role to have access to view the dashboards.

[codecov-io]

Codecov Report

Merging #5845 into master will increase coverage by 8.22%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master    #5845      +/-   ##
==========================================
+ Coverage   65.89%   74.11%   +8.22%     
==========================================
  Files         459      106     -353     
  Lines       22014    11522   -10492     
  Branches     2417        0    -2417     
==========================================
- Hits        14507     8540    -5967     
+ Misses       7386     2982    -4404     
+ Partials      121        0     -121

Impacted Files	Coverage Δ
superset/config.py	94.04% <100%> (+0.03%)	⬆️
superset/cli.py	36.91% <100%> (+0.89%)	⬆️
superset/security.py	74.8% <91.66%> (+0.83%)	⬆️
superset/db_engine_specs/sqlite.py	45.83% <0%> (-20.84%)	⬇️
superset/utils/core.py	87.93% <0%> (-0.18%)	⬇️
superset/assets/src/components/Checkbox.jsx
...ations/deckgl/layers/Polygon/PolygonChartPlugin.js
...ets/src/dashboard/components/dnd/DragDroppable.jsx
...c/visualizations/deckgl/layers/Polygon/Polygon.jsx
superset/assets/src/components/EditableTitle.jsx
... and 348 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56eac68...d50f21f. Read the comment docs.

[datinho]

I've just modified the doc 'security.rst' but Travis CI returned a timeout during the step 'Creating a dashboard':

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

If this status persists I'll try to commit again in order to activate te CI.

[datinho]

Hi all,
I think a built-in read only role/user is missing and I've tried to be complaint with the new code review process.
I've re-based the dashboard-only-rho-user branch to the master and I hope that PR cuold be merged soon.
Thanks in advance.

[mistercrunch]

We'll need unit tests making sure that a users with this role can access the things we except them to be able to access and not other things.

[datinho]

Hi @mistercrunch ,
I never did an unit test but I'll try. Just a tip, do I modify only the tests/security_tests.py or is there other files to handle?
Thanks in advance.

[mistercrunch]

https://github.com/apache/incubator-superset/blob/master/CONTRIBUTING.md#testing

[datinho]

I've added the unit test, someone can kindly give me a feedback please?
@mistercrunch @ryw @jeremi

[datinho]

Hi @mistercrunch @ryw @jeremi
could you kindly check my PR?
Thanks.

[datinho]

@hughhhh @kristw could you kindly check my PR?
Thanks.

[datinho]

@timifasubaa @mistercrunch
I'm waiting a review from 3 months during I'm still work to avoid conflict.
Do you plan to review thi PR soon?
Thanks in advance.
CC: @kristw

[datinho]

@mistercrunch @timifasubaa
could you kindly review this PR please?
Thanks in advance.

[kalimuthu123]

Not worked for me i added code in all 5 files

[datinho]

The check fails on TOXENV=cypress-dashboard, it seems a timeout problem (Travis CI side?) that
I don't have on my local environment.

1. Dashboard top-level controls should allow chart level refresh:
   CypressError: Timed out retrying: cy.wait() timed out waiting 5000ms for the 1st request to the route: 'postJson_8_force'. No request ever occurred.

[kalimuthu123]

good

[amitmiran137]

#10408

[junlincc]

Closing inactive PR in favor of #12680 @amitmiran137, thank you for your contribution! @datinho