Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to NVD3 charts (axis labels & min bar width) #629

Merged
merged 1 commit into from
Jun 17, 2016

Conversation

mistercrunch
Copy link
Member

Now the bar charts have a minimum bar width and overflow on the x axis. Also added support for axis labels on NVD3 charts.
@georgeke @williaster

@coveralls
Copy link

coveralls commented Jun 16, 2016

Coverage Status

Coverage remained the same at 81.941% when pulling 943ff09 on mistercrunch:nvd3_plusplus into 65d9feb on airbnb:master.

@mistercrunch
Copy link
Member Author

fixes #607

@georgeke
Copy link
Contributor

while you're at this, perhaps we should also add a BooleanField for "reduceXTicks" for cleaning up things like this?

screen shot 2016-06-16 at 10 49 57 am

@mistercrunch
Copy link
Member Author

Addressed comment. Mergin'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants