[sql lab] fix stuck offline #6782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6782 +/- ##
==========================================
- Coverage 56.07% 56.07% -0.01%
==========================================
Files 526 526
Lines 23257 23258 +1
Branches 2782 2782
==========================================
Hits 13042 13042
- Misses 9806 9807 +1
Partials 409 409
Continue to review full report at Codecov.
|
timifasubaa
approved these changes
Jan 30, 2019
|
Thanks for catching and fixing this |
xtinec
pushed a commit
that referenced
this pull request
Feb 8, 2019
(cherry picked from commit 36176f3)
graceguo-supercat
pushed a commit
that referenced
this pull request
Feb 8, 2019
(cherry picked from commit 36176f3)
mistercrunch
added
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit 7ffdefe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hit this weird bug where I got stuck
offline, there appeared to be no easy way to get out of that bad state. Couldn't create a new tab for reasons I don't understand. Probably the only solution would be to nukelocalstoragein the browser (and loose all unsaved tabs/queries)Polling only happens when there are running queries, so I'm guessing there are race conditions where there's no more polling happening and the UI is stuck reporting
offlineLikely the bug was introduced here #6013
This was reported at Lyft earlier this week too I think
@timifasubaa @vylc @betodealmeida
This could also be improved by polling while
offline, but I think it's also imperfect as it would not report on a case where no queries are running and the computer becomes offline. We could also poll all the time, but that's not a great idea as it would generate significantly more [not super useful] traffic in large environments.I'd say merge this asap to fix the bug and re-think what
offlinemeans and the requirements around it.