Separate vis-specific controls from centralized controls

[kristw]

Summary

Allow each visualization to define its own controls, instead of storing all controls in centralized controls.jsx

Test plan

Verified that the rose and paired t-test charts that are modified in this PR are working correctly.

@mistercrunch @williaster @michellethomas @graceguo-supercat @conglei @khtruong @xtinec

[codecov-io]

Codecov Report

Merging #6827 into master will decrease coverage by 0.03%.
The diff coverage is 64.06%.

@@            Coverage Diff             @@
##           master    #6827      +/-   ##
==========================================
- Coverage   64.94%   64.91%   -0.04%     
==========================================
  Files         424      424              
  Lines       20598    20613      +15     
  Branches     2281     2292      +11     
==========================================
+ Hits        13378    13381       +3     
- Misses       7097     7110      +13     
+ Partials      123      122       -1

Impacted Files	Coverage Δ
superset/assets/src/explore/controls.jsx	42.4% <ø> (ø)	⬆️
superset/assets/src/explore/store.js	61.64% <43.33%> (-0.2%)	⬇️
.../src/explore/components/ControlPanelsContainer.jsx	67.94% <82.35%> (-12.06%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07d9dbd...4fe63c0. Read the comment docs.

[kristw]

@mistercrunch Saw that you are doing a heavy refactor on the control panel so I am not sure when should I land this one?

[williaster]

LGTM, can see what Max says tho?

[kristw]

related to #7350
gonna have huge conflict.

[mistercrunch]

@kristw on PR #7350 I'm mostly just touching/refactoring store.js, and I think most of your changes on that file here are around naming (except for getControlItems where you go a bit deeper...). I could add flow + flatMap on my side.

Maybe you can leave your changes out on that file so I can get my PR in? Otherwise it looks like it will conflict pretty hard.

My PR addresses some of the bad names too and breaks down the big functions into smaller chunks and introduces decent test coverage.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.