Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[celery] Bump celery to 4.3.0 #7848

Merged
merged 7 commits into from
Jul 12, 2019

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jul 11, 2019

CATEGORY

  • Enhancement (new features, refinement)

SUMMARY

New celery 4.3.0 ships with the following interesting features:

  • Kumbu > 4.3.0 support for redis TLS using rediss
  • Bump the minimum eventlet version to 0.24.1
  • Added the new :setting:task_acks_on_failure_or_timeout setting
  • New Result Backend: Added the S3 result backend
  • Fix memory leak

and many others

Note

This PR also bumps (on requirements-dev) Redis to 3.2.1 this a major release change.

Breaking changes on 3.0.0
https://github.com/andymccurdy/redis-py/blob/master/CHANGES#L94

ADDITIONAL INFORMATION

  • Introduces new feature or API

@dpgaspar
Copy link
Member Author

alembic migration problem, multiple heads?

@dpgaspar
Copy link
Member Author

alembic problem could be due to this: 97ffb76#diff-ea63ff796b95e70035bc31e812b14822

no?

@mistercrunch
Copy link
Member

I see "kombu.exceptions.VersionMismatch: Redis transport requires redis-py versions 3.2.0 or later. You have 2.10.6" in the build logs

@dpgaspar
Copy link
Member Author

Right, I see it

@codecov-io
Copy link

Codecov Report

Merging #7848 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #7848   +/-   ##
======================================
  Coverage    65.8%   65.8%           
======================================
  Files         461     461           
  Lines       22090   22090           
  Branches     2422    2422           
======================================
  Hits        14536   14536           
  Misses       7433    7433           
  Partials      121     121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eccae3...8c9227b. Read the comment docs.

@mistercrunch mistercrunch merged commit 5ebc5a6 into apache:master Jul 12, 2019
@mistercrunch mistercrunch deleted the bump-celery-version branch July 12, 2019 15:42
alex-mark pushed a commit to alex-mark/incubator-superset that referenced this pull request Jul 29, 2019
[celery] Bump celery to 4.3.0 (apache#7848)

* [celery] Bump celery to 4.3.0

* re-triggering CI

* re-trigger CI

* Bump redis to 3.2.1
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants