Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
The function that replaces the query limit assumed that the limit number comes two tokens after the keyword. This was the case for
sqlparse==0.2.4
, but stopped working when bumped tosqlparse==0.3.0
. This makes the function slightly more robust by using nativesqlparse
functionality to find the next non-whitespace token after the limit keyword. The new code works equally well with0.2.4
, but I figured it's just as well to bump to the newest version.TEST PLAN
REVIEWERS
@john-bodley @betodealmeida