Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sqlparse to 0.3.0 #7973

Merged
merged 3 commits into from
Aug 5, 2019
Merged

Bump sqlparse to 0.3.0 #7973

merged 3 commits into from
Aug 5, 2019

Conversation

villebro
Copy link
Member

@villebro villebro commented Aug 2, 2019

CATEGORY

Choose one

  • Refactor

SUMMARY

The function that replaces the query limit assumed that the limit number comes two tokens after the keyword. This was the case for sqlparse==0.2.4, but stopped working when bumped to sqlparse==0.3.0. This makes the function slightly more robust by using native sqlparse functionality to find the next non-whitespace token after the limit keyword. The new code works equally well with 0.2.4, but I figured it's just as well to bump to the newest version.

TEST PLAN

  • Unit tests.

REVIEWERS

@john-bodley @betodealmeida

@codecov-io
Copy link

codecov-io commented Aug 2, 2019

Codecov Report

Merging #7973 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7973   +/-   ##
=======================================
  Coverage   65.59%   65.59%           
=======================================
  Files         469      469           
  Lines       22399    22399           
  Branches     2432     2432           
=======================================
  Hits        14693    14693           
  Misses       7585     7585           
  Partials      121      121
Impacted Files Coverage Δ
superset/sql_parse.py 99.2% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e23920b...43181c0. Read the comment docs.

superset/sql_parse.py Outdated Show resolved Hide resolved
@villebro villebro changed the title Bump sqlparse 030 Bump sqlparse to 0.3.0 Aug 2, 2019
@villebro villebro merged commit a1261d7 into apache:master Aug 5, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants