Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #7984 #7985

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Fix #7984 #7985

merged 1 commit into from
Aug 7, 2019

Conversation

mistercrunch
Copy link
Member

See #7984 for more
details

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

@mistercrunch
Fix apache#7984
1a91527 
See apache#7984 for more
details
@codecov-io
Copy link

codecov-io commented Aug 5, 2019 •
edited
Loading

Codecov Report

Merging #7985 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7985      +/-   ##
==========================================
+ Coverage   65.59%   65.59%   +<.01%     
==========================================
  Files         469      469              
  Lines       22401    22402       +1     
  Branches     2432     2432              
==========================================
+ Hits        14694    14695       +1     
  Misses       7586     7586              
  Partials      121      121
Impacted Files Coverage Δ
superset/viz.py 71.76% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ca078...1a91527. Read the comment docs.

@mistercrunch mistercrunch merged commit af2b92d into apache:master Aug 7, 2019
@mistercrunch mistercrunch deleted the fix_7984 branch August 7, 2019 04:15
@amancevice amancevice mentioned this pull request Sep 2, 2019
Closed
12 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristw kristw kristw approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.34.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mistercrunch @codecov-io @kristw @dpgaspar