Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added better display of NULL values in FilterableTable (as in SQL Lab Results) #8003

Merged
merged 4 commits into from
Aug 9, 2019
Merged

Added better display of NULL values in FilterableTable (as in SQL Lab Results) #8003

merged 4 commits into from
Aug 9, 2019

Commits on Aug 7, 2019

  1. Added better display of NULL values in FilterableTable (Reults table … 

    …as in SQL Lab results) and changed sorting order so that NULL values always come last
    @semantiDan
    semantiDan committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    7520cb8 View commit details
    Browse the repository at this point in the history

  2. fixed syntax according to elint recommendations

    @semantiDan
    semantiDan committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    d7618d0 View commit details
    Browse the repository at this point in the history

  3. changed code style and logic in getContentCell according to @etr2460 … 

    …code review
    @semantiDan
    semantiDan committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    1d8bb3a View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2019

  1. remvoved 'null-cell' class and replaced it with 'text-muted' as per @… 

    …mistercrunch review
    @semantiDan
    semantiDan committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    b630a5f View commit details
    Browse the repository at this point in the history